musescore / musescore/MuseScore

The `traitName` is not displayed when replacing or changing an instrument

Open
#22,762 0 comments 0 reactions 1 assignee View on GitHub

@Eism is already working on this.

Since May 10, 2024.

P2 regression MS3 UI UX/interaction
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Issue type

UI bug (incorrect info or interface appearance)

Bug description
  1. When replacing an instrument in the "Staff/Part properties" dialog box (as well as in the part settings in the "Instruments" palette), only the name of the instrument (full and abbreviated) is displayed in the text box, and the traitName is omitted.
  2. When changing an instrument, the traitName is also not displayed.
Steps to reproduce
  1. Open/create a score
  2. In the "Staff/Part properties" of the instrument, in the name of which the traitName should be displayed by default, replace this instrument with exactly the same one.
  3. You will see that the traitName is omitted in the text box.

The same thing happens when you change an instrument.

Expected behavior

The traitName should have been displayed in the text box.

Screenshots/Screen recordings

https://github.com/musescore/MuseScore/assets/134041121/f6107392-de7b-4224-987a-75b0729ea61e

https://github.com/musescore/MuseScore/assets/134041121/6ef0a81e-3b1e-4be5-aed4-335c48968afb

MuseScore Version

MuseScore Studio version (64-bit): 4.3.0-241231433, revision: github-musescore-musescore-5f36e74

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Windows 11

Additional context

This problem is especially relevant for international users when they need to replace the instrument with the same one, only in their language, and when faced with this problem, they have to manually add the traitName. And okay (let's say) if it's a French horn, but if it's a trumpet or clarinet in B♭, then in this case you first need to copy the ♭ symbol (and try to guess that you will have to do this before you replace the instrument).

https://github.com/musescore/MuseScore/assets/134041121/b4079d62-51a6-4d15-a509-ed436b93816b

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.