musescore / musescore/MuseScore
Accidentals probably should not be applied to non-pitched percussion
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
Issue type
UX/Interaction bug (incorrect behaviour)
Bug description
It would be best to disable using accidentals on non-pitched percussion.
Steps to reproduce
- Open a score with Drum Kit
- In note input mode, use minus to engage the flat accidental
- Write a HiHat note, it is triple-flat (no change in playback)
Also you can select a note and then click the accidentals for some general midi fun.
Screenshots/Screen recordings
https://github.com/musescore/MuseScore/assets/69917893/abc59bd5-49a8-4530-9641-4d4b9b9dd7f4
MuseScore Version
OS: macOS 14.4, Arch.: x86_64, MuseScore Studio version (64-bit): 4.4.0-241280301, revision: github-musescore-musescore-63d04f9
Regression
No.
Operating system
Mac OS 14
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the behavior in MuseScore with a Drum Kit, using note input mode and the accidental controls on a HiHat note. Trace the note-input and accidental handling for non-pitched percussion; done means accidentals cannot be applied to those notes while normal percussion entry remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100