musescore / musescore/MuseScore

Style dialog - Enter does not activate OK button, Tab does not move focus to the button group

Open
#21,907 5 comments 0 reactions 3 assignees View on GitHub

@mathesoncalum is already working on this.

Since Aug 19, 2024.

accessibility needs info needs review regression MS3
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Issue type

Accessibility issue (e.g. for keyboard-only or screen reader users)

Bug description

Enter does not operate the OK button in the Style dialog, making it difficult to operate with keyboard only. Alt+O does work on Linux but apparently not on all systems.

Compounding this, the Style dialog is still using the old navigation scheme where Tab moves to the next field instead of the next group. This is actually one of the few dialogs complex enough that really would benefit from the hierarchical navigation. I assume that requires porting to QML, but fixing Enter should be doable as a quick fix.

Worse, the dialog is large enough that it does not fit on some displays, cutting off the visibility of the OK and Cancel buttons. This leads to a lot of people closing via Esc or the "X" on the title bar, then wondering why their changes don't stick.

Steps to reproduce
  1. Format / Style
  2. Change any style value
  3. Press Tab
  4. Press Enter

Result: dialog is not closed

  1. Press Tab

Result: focus moves to next field instead of to button row

Screenshots/Screen recordings

No response

MuseScore Version

OS: Debian GNU/Linux 12 (bookworm), Arch.: x86_64, MuseScore version (64-bit): 4.2.1-240230938, revision: github-musescore-musescore-d757433

Regression

Yes, this used to work in MuseScore 3.x and now is broken

Operating system

Debian 12

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.