musescore / musescore/MuseScore
Figured bass text is not updated on undo
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
Issue type
Engraving bug (incorrect score rendering)
Bug description
Undoing an edit on a figured bass item only shows the updated text once editing is started again
Steps to reproduce
- Add a figured bass element and enter a number
- Edit the figured bass again and add a character
- Stop editing and try to undo. There is no change
- Double click to start editing again, observe the change
Screenshots/Screen recordings
https://github.com/musescore/MuseScore/assets/26510874/180dd21e-8dce-43e9-8dc2-cefff06dc102
MuseScore Version
4.2.0
Regression
No.
Operating system
macOS 13.5
Additional context
To lay out figured bass, a FiguredBassItem object is created for each line, and each line laid out separately. FiguredBassItem is sort of an unfinished EngravingItem - lots of the properties are completely unused in favour of deleting these items and recreating from scrach every time the figured bass is edited. This isn't every undo-friendly. I'd say it probably doesn't fit in very well with our new layout system and could do with a rethink and rework one day.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.