musescore / musescore/MuseScore

Incomplete Undo for several actions

Open
#19,796 5 comments 0 reactions 2 assignees View on GitHub

Nobody has claimed this yet.

lyrics needs review P1 regression MS4 UX/interaction
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Issue type

Choose option...

Bug description

Musescore 4 "undo" action results in incomplete or incorrect results. The following issues have been found:

  • When a lyric block & (one other feature, eg lyric in different verse, slur) is moved with x, undo fails to restore the lyric to the correct place. The lyric ends up in the middle of the staff (see image in Screenshots). It can be returned to the original position by hitting x twice (swapping position twice). This effect occurs for above-staff lyrics and below-staff lyric blocks.

  • When a lyric block is deleted, "undo" does not restore hyphens properly. Hyphenation after the lyric block restores properly, but preceding hyphenation does not come back.

Steps to reproduce

Steps to reproduce are in the bug description. This bus occur after software close and reopen, and after computer restart.

Screenshots/Screen recordings

Lyric placement bug when undoing lyric + (other) move with x
Lyric placement when undoing lyric + (other) move with x

_
Hyphenation bug:

Hyphenation before delete
image

Measure after delete
image

Measure after undo, with preceding hyphen missing
image

MuseScore Version

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore version (64-bit): 4.1.1-232071203, revision: github-musescore-musescore-e4d1ddf

Regression

Yes, worked in 4.0.2, broken in 4.1.0

Operating system

Windows 11

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.