musescore / musescore/MuseScore

sometimes missing accidentals on note following altered unison group

Open
#19,656 1 comment 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

engraving P3
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Issue type

Engraving bug

Bug description

If there is a chord containing altered unison, next note should have always cautionary accidental.

Now it has only sometimes.

Steps to reproduce
  1. write "unison" chord ab-a following by a
  2. write "unison" chord a-a# following by a
  3. see - first "a" without accidental is a, second is a#
Screenshots/Screen recordings

https://github.com/musescore/MuseScore/assets/1646034/4fbbedfd-5dd1-4e59-a047-54d9d406c50c

MuseScore Version

master

Regression

I don't know

Operating system

Ubuntu 22.04

Additional context

Actually, accidentalState is taken from last note of "unison" chord, which is always highest note, but I think correct behaviour is, next note should always have cautionary accidental.

Now user needs to add accidental manualy, but it causes, when note changes its octave, accidental remains there, which is wrong.

May be new accidentalState "none" should be used and aplied by altered unison chords, so any note would have shown "auto" accidental.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.