musescore / musescore/MuseScore

Undoing changing project properties interferes with publishing / saving to cloud

Open
#17,561 1 comment 0 reactions 2 assignees View on GitHub

@shoogle is already working on this.

Since May 14, 2023.

cloud P2
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

  1. Create score and save it to your computer OR open score from your computer that has never been published / saved to the cloud yet
  2. Change some project properties
    • for example, like in the video, change the title from "Changing the title" to "Changing the title to something else"
  3. Publish the score
  4. Undo
    • changes the title back to "Changing the title", but also discards the cloud save info, because it is also stored in project properties.
      (In fact, you could even say that saving to cloud corrupts the undo stack, because it modifies the project properties without informing the undo stack. But given how the ChangeMetaTags command is implemented, this does not really cause trouble, except this issue.)
  5. Save the score (don't forget, because of #17560)
  6. Close the score
    • this is necessary because as long as the score is open, the cloud info is also stored in NotationProject::cloudInfo
  7. Reopen the score
  8. Try to publish again
    • expected: Can replace/update the previously published version of this score
    • actual: MuseScore has forgotten everything about the previously published score

https://github.com/musescore/MuseScore/assets/48658420/2cbddd91-350b-4c4f-a42e-0ab691b69afd

Fixing this might also fix https://github.com/musescore/MuseScore/issues/20544.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.