musescore / musescore/MuseScore

Clef customization lost when unchecking "show clef" in staff type dialog and then undoing

Open
#17,482 0 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

P2 UX/interaction
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

  1. Create score
  2. Change the clef in measure 1 to something else
  3. Right-click the staff and choose "Staff/Part properties"; in the dialog, uncheck "Show clef"; click OK
  4. Undo
    • Expected: back in the situation before step 3, i.e. I have my changed clef back
    • Actual: my changed clef doesn't return; instead I get the default one for the instrument in question

Other way:

  1. Create score
  2. Change some property of the initial clef, for example make it purple
  3. Right-click the staff and choose "Staff/Part properties"; in the dialog, uncheck "Show clef"; click OK
  4. Undo
    • Expected: back in the situation before step 3, i.e. I have my purple clef back
    • Actual: I get a brand new black clef, instead of my purple one

On a first glance, the code in Measure::addSystemHeader seems to be the problem.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.