musescore / musescore/MuseScore
Instrument search should not require user to use umlaut or other accent marks to find instruments
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
Your idea
When I type "guiro" when searching for an instrument, "Güiro" should be one of the search results. Although this is proper for the instrument display name, the user should not need to use that character to find the instrument.
Problem to be solved
Umlauts and other accents should be included when the user searches for the instruments with those characters.
When user types "u", results should display û, ü, ù, ú, ū as well
Prior art
No response
Additional context
Related to https://github.com/musescore/MuseScore/issues/15983
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the instrument-search implementation and review related issue #15983 for context. The work is done when searches without umlauts or other accent marks return instrument names containing those characters, including the stated u/û/ü/ù/ú/ū examples.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- search
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100