musescore / musescore/MuseScore

Courtesy accidentals: Incorrect case

Open
#16,565 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

community needs testing P3 plugins
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Describe the bug
A courtesy accidental is created two bars distant from the causal accidental.

To Reproduce
Define three shortcuts:
CTL-A: RunPluginAddCourtesyAccidentals
OPT-A: RunPluginRemoveCourtesyAccidentals
CTL-OPT-A: RunPluginConfigCourtesyAccidentals

(1) Run CTL-OPT-A on the score as attached. (See screenshot.) Specify 'Put accidentals in parenthesis'.
See in bar 1 the E#. In bar 3 a courtesy Eb with parentheses has been inserted. (See screenshot.)

Expected behavior
In bar 3 there should be no courtesy Eb.

(2) Run CTL-OPT-A on the score as attached. Uncheck 'Put accidentals in parenthesis'.
A similar error occurs. But see Note.

Screenshots
Original score:
Screenshot 2023-02-27 at 10 32 28 am

Result for Case (1):
Screenshot 2023-02-27 at 10 14 57 am

9:8 bug.mscz.zip

Platform information
MacOS 13.1
Macbook M1 Pro

Additional context
Note: This error did not occur for the CTL-A case.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the attached 9:8 bug.mscz.zip score and the RunPluginConfigCourtesyAccidentals shortcut, testing both parenthesized and unparenthesized settings. Trace the courtesy-accidental behavior for the E# in bar 1 and the unexpected Eb in bar 3; done means no courtesy Eb is inserted in bar 3 while the CTL-A case remains unaffected.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.