musescore / musescore/MuseScore
Incorrect description string for Acoustic Bass instrument
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
Describe the bug
The "Add or remove instruments" dialog describes Acoustic Bass as Acoustic bass guitar..
This is incorrect; as a comment in the code clearly describes, this is how one chooses an upright bass in MuseScore.
To Reproduce
Steps to reproduce the behavior:
- Click the Add button from the Instruments panel.
- Choose
Strings - Plucked>Acoustic Bass. - Look at the description shown at the lower left of the dialog.
Expected behavior
The description should be something like Acoustic (upright) bass.
Screenshots
Platform information
- OS: macOS
Additional context
Presumably this should've been fixed when the comment was added in https://github.com/musescore/MuseScore/pull/952.
I'd be happy to submit a PR to propose a new string, though I guess the documentation for the instrument definitions spreadsheet suggests that I should let a person who already has edit access do it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.