musescore / musescore/MuseScore

"Instrument ordering" menu in Instruments Panel doesn't update instrument ordering

Open
#15,089 2 comments 0 reactions 2 assignees View on GitHub

@DmitryArefiev is already working on this.

Since May 10, 2023.

instruments needs review P2
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Describe the bug
The "instrument ordering" menu (as seen in the screenshot) doesn't change the instrument order when you choose a new one, unlike if you go to "Add" and change it from here. It does not display the current order as "customized" if it has been customized either. It does however change the brackets.

To Reproduce
Steps to reproduce the behavior:

  1. Open a score with a lot of instruments, like one for orchestra
  2. Open said menu
  3. Try to choose a different order
  4. See that only the brackets change and not the order
  5. You can try to put a random order and put the order in the menu to Orchestral, it won't do anything either.

Expected behavior
It should change the order of the instruments, the same way the "Add" menu does. It should also say "customized" if that's the case.

Screenshots
image

Platform information

  • OS: Windows 10

Additional context
The "Add" menu should be renamed to "Add & Edit" or something like that in my opinion, since I didn't think to look there at all to change the order which made me find the bug

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.