musescore / musescore/MuseScore

Preferences > Shortcuts: cannot input a shortcut of the form `Shift` + special key

Open
#14,697 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs review
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

To Reproduce
Steps to reproduce the behavior:

  1. Go to Preferences > Shortcuts

  2. Choose an action to define a shortcut for

  3. In the popup, try to enter a shortcut of the form Shift + a special key, for example:

    • Space bar
    • Backspace / delete
    • Return / Enter
    • Tab
    • the F1...F12 keys
    • Arrow keys

    -> Result: the Shift key is ignored.

Expected behavior
The Shift key should not be ignored.

Platform information

  • OS: at least macOS, but probably all of them

Additional context
In src/framework/shortcuts/shortcutstypes.h, the method correctKeyInput actively drops the Shift modifier. I think this is a left-over from MS3's shortcuts system, which worked fundamentally different. The fix is probably as simple as removing this code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/framework/shortcuts/shortcutstypes.h and inspect correctKeyInput, then reproduce the issue through Preferences > Shortcuts using Shift with special keys such as Enter, Tab, Backspace, function keys, and arrows. Done means those shortcuts retain the Shift modifier on the affected platform(s) and the shortcut-entry behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.