musescore / musescore/MuseScore
[MU4 Issue] "Replace instrument" does not change staff type; so no need for tablature options
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
Describe the bug
If you start with, say, a guitar tablature score, and use "Replace instrument" (right-click on staff) you cannot change the tablature to standard staff (or vice versa) even though this possibility seems to be implied by the UI.
For example, you have the option of "Electric Guitar" or "Electric Guitar (tab)" in "Change instruments", but whether you choose one or the other the staff remains the same.
To reproduce
- Open the attached tablature example.
change_instrument_issue.zip - Right-click on the staff and choose "Replace instrument".
- Choose "Electric Guitar".
RESULT: The staff type remains as tablature, even though you might expect this option to return a standard music staff.
Expected behavior
IMV, it is to be expected that "Replace instrument" should not change the staff type. However this should be reflected in the UI of the "Replace instrument" dialog; the tablature options can be omitted since it is only the instrument that changes.
Platform information
OS: Linux Mint 20.1, Arch.: x86_64, MuseScore version (64-bit): 4.0.0-223080420, revision: github-musescore-musescore-2c34155
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open the attached change_instrument_issue.zip example and reproduce the behavior through the staff's "Replace instrument" dialog. Inspect the dialog's instrument choices and the replacement flow. Done means the dialog no longer offers irrelevant tablature variants, while replacing an instrument preserves the existing staff type.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100