musescore / musescore/MuseScore

[MU4 Issue] "Replace instrument" does not change staff type; so no need for tablature options

Open
#14,305 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P3
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Describe the bug

If you start with, say, a guitar tablature score, and use "Replace instrument" (right-click on staff) you cannot change the tablature to standard staff (or vice versa) even though this possibility seems to be implied by the UI.

For example, you have the option of "Electric Guitar" or "Electric Guitar (tab)" in "Change instruments", but whether you choose one or the other the staff remains the same.

To reproduce

  1. Open the attached tablature example.
    change_instrument_issue.zip
  2. Right-click on the staff and choose "Replace instrument".
  3. Choose "Electric Guitar".

RESULT: The staff type remains as tablature, even though you might expect this option to return a standard music staff.

Expected behavior

IMV, it is to be expected that "Replace instrument" should not change the staff type. However this should be reflected in the UI of the "Replace instrument" dialog; the tablature options can be omitted since it is only the instrument that changes.

Platform information

OS: Linux Mint 20.1, Arch.: x86_64, MuseScore version (64-bit): 4.0.0-223080420, revision: github-musescore-musescore-2c34155

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open the attached change_instrument_issue.zip example and reproduce the behavior through the staff's "Replace instrument" dialog. Inspect the dialog's instrument choices and the replacement flow. Done means the dialog no longer offers irrelevant tablature variants, while replacing an instrument preserves the existing staff type.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.