musescore / musescore/MuseScore

[MU4 Issue] hiding instrument in instruments panel creates extra undo stack(s)

Open
#13,748 2 comments 0 reactions 1 assignee View on GitHub

@Eism is already working on this.

Since Sep 18, 2023.

P2 UX/interaction
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Describe the bug
If hide instrument in Instruments panel, it creates extra empty undo(s). User needs to press undo 2 or 3 times to show instrument back.

To Reproduce
Steps to reproduce the behavior:

  1. Click visibility icon ("eye") at instruments panel to hide instrument
  2. Click undo
  3. Instrument is still hidden, extra undo is needed

or

  1. Click visibility icon ("eye") at instruments panel to hide instrument
  2. Click it again to show instrument
  3. Click undo - instrument hides - OK
  4. Click undo again - nothing happens, extra 2 undos needed to show instrument

Expected behavior
One undo is enough.

Screenshots

https://user-images.githubusercontent.com/1646034/195701124-ef9ae4a3-098c-4367-af93-b5da3e03f6d2.mp4

Platform information

  • OS: [reported on Linux]

Additional context
Extra undo(s) are needed only for showing instrument (revert hiding). Hiding (revert showing) works as expected.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.