musescore / musescore/MuseScore

[MU4 Issue] Pressing Shift + nothing is treated as editing an element

Open
#13,680 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

P3
Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Description

Describe the bug
This is a somewhat obscure and maybe theoretical issue, but when you simply press and release the Shift key, it is treated as a keyboard shortcut that edits the selected element if it is in "edit mode" (i.e. grips are visible).

To Reproduce
Or rather, to make it apparent:
In debug builds:

  1. Select for example a hairpin
  2. press and release the shift key
  3. in the console output, you see:
    01:19:16.436 | DEBUG | main_thread | Score      | endCmd: Undo stack current macro child count: 0
    
    which indicates that a command has been executed (although it is an empty command apparently).

In all builds:

  1. Create score (1 instrument is enough)
  2. enter a tempo marking on measure 3 and 5, so that mmrests will be broken
    (alternatively: enter a ritenuto spanning measure 3 and 4)
  3. enter a hairpin spanning measure 2, 3 and 4 (so three measures in total)
    Note that the hairpin now starts at the start of the first mmrest:
    Scherm­afbeelding 2022-10-10 om 01 27 22
  4. select the hairpin
  5. select the start grip of the hairpin
  6. press and release the Shift key
    Although you think you have not done anything, the start of the hairpin suddenly jumps to the second mmrest:
    Scherm­afbeelding 2022-10-10 om 01 28 55

Expected behavior
Shift + nothing = nothing

Platform information

  • OS: reported on macOS

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named in the issue, so begin by reproducing the Shift-only action with the listed hairpin and debug-build scenarios. Trace the keyboard handling and command output involved; done means pressing and releasing Shift alone produces no edit, movement, or command.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.