musescore / musescore/MuseScore
Edge case with "Follow system theme" when changing system theme while Preferences dialog is open and you then click Cancel
@cbjeukendrup is already working on this.
Since Feb 28, 2025.
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
To Reproduce
Steps to reproduce the behavior:
(requires that "Follow system theme" is enabled)
- Open Preferences (no need to actually change anything)
- Change system theme. In this example we assume that you change from light to dark mode. MuseScore should switch to the dark theme as well, as expected.
- Click "Cancel" to close the dialog
- MuseScore unexpectedly switches back to light theme.
Expected behavior
It should stay in dark theme, because it was told to follow the system theme. Just opening the Preferences dialog and clicking "Cancel" should not interfere with that.
Platform information
- OS: reported on macOS
Additional context
This is due to the way how the "cancel-ability" in the Preferences dialog is implemented. When the Preferences dialog is open, ANY change to any setting will be reverted when the user clicks "Cancel", even when that change was not made by the user but automatically.
Either we need a way to "circumvent" the automatic reversion when that is required, or the "Follow system theme" functionality should do its job in a different way rather than using the settings().
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.