musescore / musescore/MuseScore
Default workspace name not translatable, because logic relies on it
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
Describe the bug
The name of the default workspace ("Default") is not translatable, and we can't easily make it translatable because there is some logic relying on it (logic to determine which one is the built-in default workspace).
To Reproduce
Steps to reproduce the behavior:
- See status bar, and see the source code,
workspacetypes.h
We should make a better way to determine which workspace is the default one, instead of relying on the name. (I don't think we should still have logic relying on the name after we make it translatable. Relying on translatable names is asking for trouble, if you ask me.)
(For the translators, this doesn't have high priority, because the string "Default" already exists in other contexts, so Transifex's translation memory will just copy the translation from those strings.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading workspacetypes.h and tracing the status-bar workspace logic that identifies the built-in default workspace. Separate that identification from the displayed workspace name so the “Default” string can be translated. Done means the default workspace is still recognized reliably when its name is localized.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, internationalization
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100