musescore / musescore/MuseScore
[MU4 Issue] Numbers etc. not localized
@Eism is already working on this.
Since Jul 28, 2023.
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Description
Describe the bug
Some languages use different notations for numbers. For example, in Dutch, decimal numbers are written using a comma instead of a point, for example 3,1415 instead of 3.1415. However, MuseScore always notates them using a point.
To Reproduce
Steps to reproduce the behavior:
- Select Dutch as the current language
- Find a decimal number input (there are plenty in the Inspector)
- It displays the number using a point
Expected behavior
The notation of numbers and other data types should match the conventions for the currently selected language.
Platform information
- OS: reported on macOS
Additional context
This might also apply to dates and other data types.
In the case of number inputs, this is the fault of DoubleInputValidator, which is implemented in a very locale-unaware manner.
See also https://doc.qt.io/qt-6/qtquick-internationalization.html#5-use-lx-so-numbers-are-localized, which we can use to automatically localize numbers that appear inside a string.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.