multimediallc / multimediallc/codeowners-plus
Bug: approvals not dismissed for merge commit with diff
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 41
- Forks
- 13
- Avg merge
- 5d 14h
- Merged PRs (30d)
- 4
Description
This was a one time occurrence with no clear cause. The PR and commit involved are private and have been shared in DMs with @BakerNet
The scenario was:
- PR opened with multiple (4) required review groups
- After a comment and some changes, all required approvals were granted
- Branch had a merge conflict with master, and the resulting merge commit included a diff in one of the PR's files
i. The particular file was owned by one (1) review group, and this is probably not relevant, but in case it is, I (the PR author) am a member and maintainer of that review group. - Merge commit pushed, codeowners-plus bot rechecks PR
Expected: codeowners-plus bot dismisses reviews from owners of the file with the merge conflict diff
Actual: codeowners-plus bot comments "Codeowners reviews satisfied" and PR remains approved and clear to merge
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reported sequence: approved PR, merge conflict with master, a merge commit containing a file diff, and the bot's recheck. Reproduce it with an accessible PR or fixture; done means the bot dismisses approvals from owners of the changed file instead of reporting that codeowners reviews are satisfied.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, go
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100