multimediallc / multimediallc/codeowners-plus
Bug: Review requests not dismissed when required reviews satisfied
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 41
- Forks
- 13
- Avg merge
- 5d 14h
- Merged PRs (30d)
- 4
Description
NOTE: Heavily edited from original Issue submission (see Edits)
When an file has an OR rule for multiple codeowner groups, the system does not dismiss unneeded reviewer groups when one of the codeowners groups is satisfied.
- File 1 requires team A or B to approve
- A member of team A approves, satisfying the required reviews for File 1
- Team B still requested for review
Expected Behavior:
Since the rule A or B is satisfied by A approval, the requested review for B is no longer necessary, and ought to be dismissed
Actual Behavior:
The system keeps the review request for group B active, even though it's already been satisfied.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests; start by tracing the codeowner OR-rule handling and review-request dismissal path. Reproduce the A-or-B scenario, then verify that approving A removes the unnecessary request for B while preserving required review behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, go
- Domain
- developer-experience, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100