multimediallc / multimediallc/codeowners-plus

Latest version of Rerun-Action stops CodeOwners step from passing.

Open Beginner friendly
#195 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
41
Forks
13
Avg merge
5d 14h
Merged PRs (30d)
4

Description

Summary

The README's GitHub Actions Setup workflow keys its concurrency group on the branch, but check runs are published against a commit:

concurrency:
  group: codeowners-${{ github.ref }}
  cancel-in-progress: true
on:
  pull_request:
    types: [opened, reopened, synchronize, ready_for_review, labeled, unlabeled]

ready_for_review, labeled and unlabeled fire without changing the head SHA, so one commit can collect two Run Codeowners Plus runs. GitHub does not dedupe check runs by name. The first run will be cancelled while the second one succeeds. It reads as a codeowners-plus rejection. Important to note is that this can block CI if a user makes the step required. (We do not.)

What made it start failing: shqear93/rerun-checks v3.1.0

Pairing this workflow with rerun-checks to re-evaluate on pull_request_review: submitted is the trigger. Upstream commit 50237c74 changed target selection from one match to all matches:

checkRuns.find(cr => cr.name === name)     // before one target, nothing to collide with
checkRuns.filter(cr => cr.name === name)   // v3.1.0 one target per duplicate

Reproduction

  1. Push a commit.
  2. Set draft as ready to review, then set it back to draft. This will stack multiple runs of CO plus on the commit.
  3. Submit any review. A plain comment review works. Both re-run and one is cancelled.

Suggested change

In the README and in this repo's own .github/workflows/codeowners.yml:

 concurrency:
   group: codeowners-${{ github.ref }}
-  cancel-in-progress: true
+  cancel-in-progress: false

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Update the concurrency setting in README and .github/workflows/codeowners.yml. Start by comparing the GitHub Actions Setup workflow with the reproduction steps, then verify that repeated events for one commit no longer cancel the successful Codeowners Plus run.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.