multimediallc / multimediallc/codeowners-plus
Allow inheriting higher level owner
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 41
- Forks
- 13
- Avg merge
- 5d 14h
- Merged PRs (30d)
- 4
Description
It is sometime useful to have teams able to approve changes everywhere in a repository (e.g. teams performing large scale refactoring, etc.). As far as I understand the codeowners-plus documentation there is no easy way to support that for now (basically that team would need to be listed as an OR in every single rule in every .codeowners file in the repo, and the team would end up being added to all the PR).
Could some option be added to support this workflow?
Maybe with a new option in the codeowners.toml file that would make it so that any rule of a higher level .codeowners that matches files covered by a lower level .codeowners would be implicit OR rules. These implicit owners would not be added to the PR, not even be notified. But if they approve the PR their ownership would be sufficient to validate the review.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading how codeowners.toml and nested .codeowners rules are currently handled; the issue names no source files or tests. Done means a configuration option lets higher-level owners satisfy approval without being listed or notified on the PR, while supporting the described repository-wide refactoring workflow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, go
- Domain
- developer-experience, devtools
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100