multiformats / multiformats/rust-multiaddr
Should we add an empty MA to the failure test?
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 101
- Forks
- 56
- PR merge metrics
- No merged PRs in 30d
Description
Seems that the spec doesn't allow an empty MA.
Human-readable multiaddr: (/<protoName string>/<value string>)+
Example: /ip4/127.0.0.1/udp/1234
Machine-readable multiaddr: (<protoCode uvarint><value []byte>)+
Same example: 0x4 0x7f 0x0 0x0 0x1 0x91 0x2 0x4 0xd2
Values are usually length-prefixed with a uvarint
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the failure test for parsing multiaddrs and compare its cases with the quoted human-readable and machine-readable specifications. Determine whether an empty multiaddr is expected to fail, then update the test coverage so the intended behavior is explicit.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100