multiformats / multiformats/js-multiformats

Skypack build failing with multiformats@9.4.5

Open
#115 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
268
Forks
57
PR merge metrics
No merged PRs in 30d

Description

multiformats module was previously working fine in skypack, but with the latest release (9.4.5) its build is now failing, as you can see in https://codepen.io/vascosantos/pen/qBjByRo?editors=0011

image

The build error can be seen in https://cdn.skypack.dev/error/build:multiformats@v9.4.5-XS9DnCaqHDNVqc6Q8qvD . Doing a simple https://cdn.skypack.dev/multiformats@9.4.4/cid works fine, but if we change the version to the next one it will be forwarded for the build error: https://cdn.skypack.dev/multiformats@9.4.5/cid

From 9.4.5 only setup node action was changed. Also, it seems that ipjs did not have any release between 9.4.4 and 9.4.5. With this in mind, I am clueless at this point of what is the problem here.

Any ideas @rvagg ?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Skypack build using the linked CodePen and the error URLs, comparing multiformats@9.4.4 with 9.4.5. Inspect the setup-node action change in commit f6962e6d551da49dd6d717bed9a717873110a6e and determine what causes the external build failure; done means the 9.4.5 /cid URL builds successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.