Possibility to opt out of removing `data-testid` from icons on production
Open
@Janpot is already working on this.
Since Apr 1, 2025.
scope: icons
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Description
Summary
Removing the data-testid from icons only for production is very confusing because if you run e2e tests with the production version, as we do, you might have your tests running locally when implementing them, because you use the dev version, but have them fail on CI that uses the prod version. If you forget about this point you might have to wait for the CI to finish to figure out the issue. This also makes debugging very difficult unless you're aware of this subtlety.
Is it possible to add some flag/env var to opt out of removing the data-testid?
Related PR.
Examples
No response
Motivation
No response
Search keywords: icons, testid, data-testid
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.