mui / mui/material-ui

[dialog] NVDA is reading the close button in an unusual way

Open
#45,667 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

accessibility external dependency ready to take scope: dialog
Dominant language
JavaScript
Stars
99.1k
Forks
32.5k
Avg merge
2d 17h
Merged PRs (30d)
106

Description

Steps to reproduce
  1. Visit the link: https://mui.com/material-ui/react-dialog/#customization
  2. Click on the sandbox link: https://codesandbox.io/embed/mtd9sl?module=/src/Demo.tsx&fontsize=12
  3. Navigate to the close button using the Tab key.
  4. You'll notice that NVDA reads the close button's title twice, followed by the content, and then also announces the save button.
  5. After making the change in the nvda setting i.e Disable Automatic say all on page load option under browse mode, then it is reading close button twice as below. Attached the same screen shot.
  6. However, JAWS is reading it correctly, announcing the "Modal title dialog close button."
  7. I am using NVDA Version 2024.1(2024.1.0.31547)
  8. Please refer to the attached screenshots for reference.
    Image

Image

Image

Image

Current behavior

NVDA is reading close button in unusual way.

Expected behavior

NVDA should read the close button only once, similar to how JAWS reads it.

Context

No response

Your environment
npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: accessibility

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Dialog customization demo at mui.com/material-ui/react-dialog/#customization and its linked /src/Demo.tsx CodeSandbox. Reproduce the close-button announcement with NVDA 2024.1, comparing the reported behavior with JAWS. Done means NVDA announces the close button only once, as expected.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.