mui / mui/material-ui

[RFC] Start a small collaboration with RJSF to enhance the Material UI theme they have created?

Open
#45,011 2 comments 2 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

ready to take RFC scope: all components waiting for 👍
Dominant language
JavaScript
Stars
99.1k
Forks
32.5k
Avg merge
2d 17h
Merged PRs (30d)
106

Description

What's the problem?

The RJSF library has a community-maintained Material UI theme. The library is actively maintained and used in many projects.

However, some widgets do not properly use Material UI theming. There is the data-url widget and the date & time ones: date, date-time, and time. Documentation here.

I'm sure there are developers here who had to build their custom widgets for the RJSF Material UI theme to conform to Material Design properly. Even sharing these examples would be helpful for those who don't yet have their solutions.

I decided to start this RFC after noticing that besides the date & time widgets missing, the data-url (file) widget is also missing proper Material UI integration. Creating this widget does not seem like a huge endeavor.

@oliviertassinari What do you think? Could the Material UI team consider contributing to the RJSF Material UI theme at some point?
Even just documentation examples (either on our side or theirs) would greatly help. I opened an issue regarding this over at rjsf-team/react-jsonschema-form#4447.
The Material UI theme for RJSF was, at least for me, a deciding factor in adopting Material UI overall in my project.
As a taste of what this would take, here's an issue I opened where I made a custom Material UI password widget for RJSF, with an eye icon to show/hide the input: rjsf-team/react-jsonschema-form#4274

What are the requirements?

No response

What are our options?

No response

Proposed solution

No response

Resources and benchmarks

No response

Search keywords:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.