[material-ui] Sign-in template improvements
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Description
The issue I can see on https://master--material-ui.netlify.app/material-ui/getting-started/templates/sign-in/ and https://master--material-ui.netlify.app/material-ui/getting-started/templates/sign-in-side/:
- 1. People would zoom because they have struggle reading, can't access the buttons. It's impossible to scroll: https://github.com/mui/material-ui/pull/43396
- 2. This should likely be a color primary https://github.com/mui/material-ui/pull/43220
- 3. This textfield doesn't exist in Material Design
- 4. There are more violations on the page https://validator.w3.org/nu/?doc=https%3A%2F%2Fdeploy-preview-42605--material-ui.netlify.app%2Fmaterial-ui%2Fgetting-started%2Ftemplates%2Fsign-in%2F
- 5. We are missing landmark on the page no? Axe complains about it
- 6. The focus UI is strange, I don't understand why the outline is not right on the border. Is here other websites using a double focus border? I don't see it working well: https://github.com/mui/material-ui/pull/43220
- 7. Padding should be added to the
<input>not it's container, because of autofill style:
this would be correct
- 8. I assume that https://mui.com/material-ui/getting-started/templates/sign-in-side/ is a mistake. Showing infos on the side only makes sense for a sign up?
- 9. The "forgot your password?" button is in the tab sequence between email and password. I don't think this can work. it should be after the submit button. https://auth.planetscale.com/sign-in, https://auth.campsite.com/sign-in. I mean, nobody does what our template does?
https://github.com/user-attachments/assets/26f339a8-ded7-4e24-86a7-7404f88317ff
#44281
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the sign-in and sign-in-side templates linked in the issue, then inspect the reported validator.w3.org and Axe violations. Review the unchecked items for the text field, landmarks, autofill padding, side-panel content, and tab order; done means the agreed template behavior and accessibility checks pass without regressing the completed items.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- accessibility, design, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100