mui / mui/material-ui

[icons] Material Icons do not support Joy UI's "danger" color prop

Open
#42,325 4 comments 0 reactions 1 assignee View on GitHub

@siriwatknp is already working on this.

Since May 22, 2024.

on hold package: joy-ui scope: icons
Dominant language
JavaScript
Stars
99.1k
Forks
32.5k
Avg merge
2d 17h
Merged PRs (30d)
106

Description

Steps to reproduce

Link to live example:

Steps:

  1. Import any Icon from "@mui/icons-material"
  2. Import Button from "@mui/joy"
  3. Set the color prop on any Icon to "danger"
Current behavior

Type '"danger"' is not assignable to type '"primary" | "success" | "warning" | "disabled" | "action" | "inherit" | "secondary" | "error" | "info" | undefined'.

Expected behavior

Expected behavior is for the icon to inherit the red "danger" color, as is the case with all Joy components.

Context

I'm trying to use it to create simple label strings (in )

Your environment
npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: Icons, Icons-Material, Joy UI, Danger

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.