[material-ui] Standardize event handler callbacks
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 20/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript, react
- Domain
- frontend
Research direction
Start by reviewing the marked callback in packages/mui-material/src/internal/SwitchBase.js and the Select callback in packages/mui-material/src/Select/SelectInput.js. Read the Base UI refactor context and related pull request #40210. Done means agreeing on a consistent callback-signature strategy across the library and its Base UI integration.
Written by the indexing model from the issue text.
Description
Review, design, and standardize the event handler callback signatures across the library.
Some are marked to be modified: https://github.com/mui/material-ui/blob/next/packages/mui-material/src/internal/SwitchBase.js#L116-L119
While others aren't: https://github.com/mui/material-ui/blob/next/packages/mui-material/src/Select/SelectInput.js#L258
With the Base UI refactor on the horizon, this issue should be handled alongside it, as it will be tightly related. For example, while working on https://github.com/mui/material-ui/pull/40210, one of the blockers was that the Select component's onChange second argument was not supported by Base UI.
Overall, we should decide the optimal way to support custom callback signatures or if we should only rely on events API.
Search keywords:
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mui/material-ui
-
type: new feature waiting for 👍
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
mui/material-ui#48254 · 3 comments · 1 reaction ·
-
has workaround scope: avatar waiting for 👍
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
mui/material-ui#48190 · 5 comments ·
-
has workaround scope: typography type: new feature waiting for 👍
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
mui/material-ui#46488 · 2 comments · 1 reaction ·
-
has workaround scope: text field type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
mui/material-ui#37216 · 6 comments ·
-
docs scope: autocomplete
Difficulty 1/5 1-3 hours Newbie friendliness 68/100
mui/material-ui#35713 · 5 comments ·
Similar issues
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·
-
status: needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100