[material-ui][Collapse] Deprecate `sx` prop
Open
Nobody has claimed this yet.
component: Collapse
deprecation
scope: transitions
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Description
Transitions shouldn't support the sx prop:
- https://github.com/mui/material-ui/pull/32025#pullrequestreview-924655864
- https://github.com/mui/material-ui/pull/32025#issuecomment-1106271947
The Collapse transition is the only one with it in its types. We should deprecate it and mark it as to be removed. We should also add instructions on migrating on the migrating from deprecated APIs guide. We could also try adding a codemod, but I'm unsure how it should work.
Search keywords:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Collapse type definitions and the migrating from deprecated APIs guide linked in the issue. Confirm the deprecation and removal guidance for the sx prop, then document the migration there; treat codemod support as a separate decision because its behavior is unspecified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- documentation, frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100