[joy-ui][Drawer] Unmount children when Drawer is closed
Open
@siriwatknp is already working on this.
Since Oct 2, 2023.
on hold
package: joy-ui
scope: drawer
type: enhancement
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Description
Duplicates
- I have searched the existing issues
Latest version
- I have tested the latest version
Summary 💡
Not sure if this is intended, but currently the Drawer component in Joy UI always keeps its children mounted, even when clsoed. There also isn't a keepMounted option to change this behavior. This is different from Modal, which by default unmounts its children when closed.
Examples 🌈
Line in Modal that unmounts the children when the Modal is closed: https://github.com/mui/material-ui/blob/07730e88ae7491451bc5ff7dfd57dd710bd9d658/packages/mui-joy/src/Modal/Modal.tsx#L142
Motivation 🔦
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.