[joy-ui][Button] Improve disabled buttons' text selection
Open
Nobody has claimed this yet.
on hold
package: joy-ui
scope: button
type: enhancement
waiting for 👍
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Description
Duplicates
- I have searched the existing issues
Latest version
- I have tested the latest version
Summary 💡
Joy's button text selection should behave as follows:
- Text selection from outside is possible
- Text selection from double-click is not possible
This seems to be the most common behavior. Right now, this is implemented for enabled buttons, but not disabled ones.
Examples 🌈
You can see this behavior in Chrome and Safari in: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button
https://github.com/mui/material-ui/assets/16889233/ac945e8f-fd77-45ea-b34f-28fe72d962fa
In Firefox, the buttons' text is not selectable.
Motivation 🔦
Following up on Point 13 of this comment: https://github.com/mui/material-ui/pull/36622#issuecomment-1644790976.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.