mui / mui/material-ui

[internal] Define rules to modularize packages in Next.js

Open
#38,736 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

internal nextjs performance type: enhancement
Dominant language
JavaScript
Stars
99.1k
Forks
32.5k
Avg merge
2d 17h
Merged PRs (30d)
106

Description

From https://github.com/mui/material-ui/pull/35457#issuecomment-1676416983

we can scale this (modularizing the icons package) to all the MUI npm packages, beyond @mui/icons-material. It could be done with special rules, like in https://github.com/vercel/next.js/blob/261db496f7cf04b70f078a6eae0c8baf6fe5c238/packages/next/src/server/config.ts#L738. I didn't have time in https://github.com/vercel/next.js/pull/51953 to do it right, there was an urgency to fix it before it was rolled from their canary release to stable. Then, the question is is the Next.js job to keep this up to date? Is there a similar opportunity with Vite, should we update the Vite example as well? At the end of the day, it's about improving the DX.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked MUI pull request discussion and the referenced Next.js packages/next/src/server/config.ts rule at line 738. Determine how package modularization rules should cover MUI npm packages, whether Next.js should maintain them, and whether the Vite example needs the same treatment. Done means the scope and ownership of those rules are defined.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, next.js, react, vite
Domain
developer-experience, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.