mui / mui/material-ui

[system] Remove custom behavior for sx={{ width: 1 }}

Open
#38,583 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breaking change discussion scope: system v6.x
Dominant language
JavaScript
Stars
99.1k
Forks
32.5k
Avg merge
2d 17h
Merged PRs (30d)
106

Description

Duplicates
  • I have searched the existing issues
Latest version
  • I have tested the latest version
Summary 💡

https://mui.com/system/sizing/

<Box sx={{ width: 1 }} />

feels a bit like a foot gun. I would expect 1px, not 100%. This discussion started in https://github.com/mui/mui-x/pull/5177/files#r895041464.

Examples 🌈

I would propose:

diff --git a/packages/mui-system/src/sizing.js b/packages/mui-system/src/sizing.js
index 0454dfb170..c6c8920e49 100644
--- a/packages/mui-system/src/sizing.js
+++ b/packages/mui-system/src/sizing.js
@@ -3,7 +3,7 @@ import compose from './compose';
 import { handleBreakpoints, values as breakpointsValues } from './breakpoints';

 export function sizingTransform(value) {
-  return value <= 1 && value !== 0 ? `${value * 100}%` : value;
+  return value < 1 && value > 1 ? `${value * 100}%` : value;
 }

 export const width = style({
Motivation 🔦

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with packages/mui-system/src/sizing.js and compare the current sizing behavior with the sizing documentation at mui.com/system/sizing/. Confirm the intended result for sx={{ width: 1 }} and adjust the custom transformation accordingly. Done means the value no longer receives the special percentage behavior described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.