mui / mui/material-ui

[Joy][Stack] `direction` prop as object breaks `spacing` prop

Open
#37,904 3 comments 0 reactions 1 assignee View on GitHub

@siriwatknp is already working on this.

Since Jul 11, 2023.

component: Stack scope: system type: bug
Dominant language
JavaScript
Stars
99.1k
Forks
32.5k
Avg merge
2d 17h
Merged PRs (30d)
106

Description

Duplicates
  • I have searched the existing issues
Latest version
  • I have tested the latest version
Steps to reproduce 🕹

https://codesandbox.io/s/exciting-cherry-h3g5mz?file=/demo.tsx

Current behavior 😯

On small (sm) window, the spacing prop as string is not applied when using the direction prop as object (for breakpoints mapping). It works as expected if both are objects or both are strings.

Expected behavior 🤔

I expect the props to work in any combination.

Context 🔦

No response

Your environment 🌎
npx @mui/envinfo
  System:
    OS: macOS 13.4.1
  Binaries:
    Node: 20.4.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.7.2 - /usr/local/bin/npm
  Browsers:
    Chrome: 114.0.5735.198
    Edge: Not Found
    Safari: 16.5.1
  npmPackages:
    @emotion/react: 11.11.1 => 11.11.1
    @emotion/styled: 11.11.0 => 11.11.0
    @mui/base:  5.0.0-beta.6
    @mui/core-downloads-tracker:  5.13.7
    @mui/joy: 5.0.0-alpha.86 => 5.0.0-alpha.86
    @mui/private-theming:  5.13.7
    @mui/styled-engine:  5.13.2
    @mui/system:  5.13.7
    @mui/types:  7.2.4
    @mui/utils:  5.13.7
    @types/react: 18.2.14 => 18.2.14
    react: 18.2.0 => 18.2.0
    react-dom: 18.2.0 => 18.2.0
    typescript: 5.1.6 => 5.1.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.