mui / mui/material-ui

SpeedDial cannot have children other than SpeedDialAction

Open
#37,030 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

scope: speed dial type: enhancement
Dominant language
JavaScript
Stars
99.1k
Forks
32.5k
Avg merge
2d 17h
Merged PRs (30d)
106

Description

Duplicates
  • I have searched the existing issues
Latest version
  • I have tested the latest version
Steps to reproduce 🕹

Link to live example:
https://codesandbox.io/s/admiring-moore-8ftlq3?file=/src/App.tsx

Steps:

  1. Hover over SpeedDial and see no menu is shown
  2. Comment out the two spans inside SpeedDial
  3. Things work as expected
Current behavior 😯

Cannot nest anything inside SpeedDial as it breaks SpeedDialActions

Expected behavior 🤔

You should be able to nest other things inside SpeedDial around the SpeedDialActions.

Context 🔦

The plan was to customise the SpeedDial by putting the SpeedDialActions inside a component, so the user can rearrange the order.

Your environment 🌎
npx @mui/envinfo
Browser Chrome

System:
    OS: Windows 10 10.0.19042
  Binaries:
    Node: 19.3.0 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 8.15.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.19041.1266.0), Chromium (112.0.1722.58)
  npmPackages:
    @emotion/react: ^11.10.6 => 11.10.6
    @emotion/styled: ^11.10.6 => 11.10.6
    @mui/base:  5.0.0-alpha.126
    @mui/core-downloads-tracker:  5.12.1
    @mui/icons-material: ^5.11.16 => 5.11.16
    @mui/material: ^5.12.1 => 5.12.1
    @mui/private-theming:  5.12.0
    @mui/styled-engine:  5.12.0
    @mui/system:  5.12.1
    @mui/types:  7.2.4
    @mui/utils:  5.12.0
    @types/react: ^18.0.28 => 18.0.28
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    typescript: ^4.9.5 => 4.9.5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked CodeSandbox and inspect the SpeedDial and SpeedDialAction entry points involved when spans are nested around the actions. Reproduce the failure with the extra children present, then verify that other children can be nested while the SpeedDialActions menu still appears and operates correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.