[Tooltip] Disable context menu when long-pressing a Tooltip
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Description
Duplicates
- I have searched the existing issues
Latest version
- I have tested the latest version
Summary 💡
I just tried trigger MUI Tooltip by long press, and found it annoying that the context menu would appear as well 🙁
Examples 🌈
https://user-images.githubusercontent.com/7490144/232953923-e3ef3f43-036e-4560-bd48-cf3eab1dd13f.mp4
Motivation 🔦
I propose we can add a new prop: disableContextMenu, and default to disableTouchListener === false.
With disableContextMenu === true, pass onContextMenu: e => e.preventDefault() in props for cloning children
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/mui-material/src/Tooltip/Tooltip.js, at the props for cloning children linked in the issue, and trace how touch-triggered tooltips handle context menus. Confirm the desired default for disableContextMenu and verify that long-pressing a Tooltip no longer opens the context menu when the option is enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100