Latest 5.10.7 Causes duplicate classes in snapshots
Open
Nobody has claimed this yet.
component: FormControl
scope: text field
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Description
Duplicates
- I have searched the existing issues
Latest version
- I have tested the latest version
Steps to reproduce 🕹
Steps:
- upgrade to 5.10.7 from 5.10.6
Current behavior 😯
>
Sprite Icons
</h2>
<label
- class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-shrink MuiFormLabel-colorPrimary emotion-120"
+ class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-shrink MuiFormLabel-colorPrimary MuiInputLabel-root MuiInputLabel-shrink emotion-120"
data-shrink="true"
id="demo-simple-select-label"
>
### Expected behavior 🤔
Take a look, the classes like MuiInputLabel-root are getting doubled up.
### Context 🔦
Jest snapshots should match without duplicate classes.
### Your environment 🌎
<details>
<summary><code>npx @mui/envinfo</code></summary>
jest
</details>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Jest snapshot difference while upgrading from 5.10.6 to 5.10.7, using the duplicate MuiInputLabel classes shown in the issue as the check. Trace the snapshot-rendered component and compare the generated class lists; done means the affected snapshots no longer contain duplicated classes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100