mui / mui/material-ui

[material-ui][Button] Height is at 36.5px instead of 36px

Open
#34,072 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

design: material has workaround scope: button type: expected behavior
Dominant language
JavaScript
Stars
99.1k
Forks
32.5k
Avg merge
2d 17h
Merged PRs (30d)
106

Description

Duplicates
  • I have searched the existing issues
Latest version
  • I have tested the latest version
Current behavior 😯

Honestly this is such a small thing but it bugs me to no end when trying to setup things in the UI consistently. The button height measures out to 36.5px when bring inspected in Chrome/Firefox/Edge when the height should be at 36px.

There seem to be some other components that were effected as well. Subtitle2 was a 22px high I believe and now its some fraction. My assumption is this was due to a browser update.

Again this is in no way a huge issue just something I have noticed.

Expected behavior 🤔

Button height should be at 36px not 36.5px

Steps to reproduce 🕹

Steps:

1.Go to MUI in any browser
2. Inspect the button component
3. View the height result

Context 🔦

It would be nice if the output height of components were not decimals at it makes precision aligning and component altering a bit more difficult when decimals need to be used.

Your environment 🌎
npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Reproduce the Button height in Chrome, Firefox, and Edge, then trace the Material UI Button styling and related component typography to identify the cause of the fractional measurement. Done means the Button measures 36px without regressing the other affected components.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
design, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.