mui / mui/material-ui

ReactSwipeableView is resulting in errors with react 18

Open
#33,274 11 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

docs external dependency scope: tabs
Dominant language
JavaScript
Stars
99.1k
Forks
32.5k
Avg merge
2d 17h
Merged PRs (30d)
106

Description

Duplicates
  • I have searched the existing issues
Latest version
  • I have tested the latest version
Current behavior 😯

SwipeableDrawer is resulting in the following console error in react 18:

Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code.

There is a related issue here, but it is getting no traction so far.

Expected behavior 🤔

No error with react 18.

Steps to reproduce 🕹

Steps:

Context 🔦

No response

Your environment 🌎
npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ReactSwipeableView used by SwipeableDrawer and reproduce the reported UNSAFE_componentWillReceiveProps warning under React 18; the related react-swipeable-views issue may provide context. Done means the warning no longer appears with React 18.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.