[slider] Show value tooltip when hovering a slider thumb with disableSwap true
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Description
Duplicates
- I have searched the existing issues
Latest version
- I have tested the latest version
Summary 💡
Hovering on a slider thumb should make a tooltip with the thumb's value pop out when valueLabelDisplay is set to auto and disableSwap is set. Just like it does when disableSwap is not set.
Examples 🌈
https://codesandbox.io/s/pensive-dream-w91mx?file=/src/App.js
In this example, the only difference between the two sliders is that disableSwap is set on the second one.
A tooltip showing the value of the thumb should pop out when hovering on the thumb regardless of whether disableSwap is set or not.
Motivation 🔦
I don't think that setting disableSwap should change the behavior of valueLabelDisplay.
It is unexpected and makes disableSwap unusable when you need to maintain the ability to show the thumbs' value on hover.
I thought it was a bug at first, but it seem it may have been the intended behavior (https://github.com/mui-org/material-ui/pull/25547#pullrequestreview-623291082), so I'm filing a feature request instead.
I could take a stab at it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the /src/App.js example in the linked CodeSandbox and compare the two sliders, focusing on valueLabelDisplay="auto" with and without disableSwap. Done means hovering either thumb shows its value tooltip in both configurations without changing the existing disableSwap behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100