mui / mui/material-ui

MuiButtonBase-root-MuiMenuItem-root ignores theme override MuiMenuItem (MUI V5.1.0)

Open
#29,703 12 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

scope: select type: bug
Dominant language
JavaScript
Stars
99.1k
Forks
32.5k
Avg merge
2d 17h
Merged PRs (30d)
106

Description

Duplicates
  • I have searched the existing issues
Latest version
  • I have tested the latest version
Current behavior 😯

I wanted to change the height of my MenuItems globally through a theme override. However, there is another class still overriding the override.

Screenshot 2021-11-16 at 16 12 41

The green arrow is my setting min-height: 4.8rem. The red arrow is the overriding property (MuiButtonBase-root-MuiMenuItem-root min-height).

Expected behavior 🤔

I expect my override (the green arrow) to be the top property, overriding the MuiButtonBase-root-MuiMenuItem-root min-height: auto

Steps to reproduce 🕹

Using plain Select and MenuItem components.

My createTheme:

import { createTheme } from '@mui/material/styles';
import { theme } from './main-theme';

const muiTheme = createTheme({
    palette: {
        primary: {
            main: theme.colors.primary,
            dark: theme.colors.primary,
            light: theme.colors.primary,
        },
    },
    typography: {
        htmlFontSize: 10,
        fontSize: 14,
        fontFamily: ['"Open Sans"', '"sans-serif"'].join(','),
    },
    components: {
        MuiTableCell: {
            styleOverrides: {
                root: {
                    fontSize: '1.6rem',
                },
            },
        },
        MuiMenuItem: {
            styleOverrides: {
                root: {
                    minHeight: '4.8rem', 
                },
            },
        },
        MuiSelect: {
            styleOverrides: {
                root: {
                    fontSize: '1.6rem',
                    width: '100%',
                    backgroundColor: 'var(--color-gray-100)',
                },
                icon: {
                    color: 'var(--color-secondary)',
                },
            },
        },
    },
});

export { muiTheme };
Context 🔦

No response

Your environment 🌎
`npx @mui/envinfo`
Browsers checked: Firefox developer and Safari

System:
    OS: macOS 11.6
  Binaries:
    Node: 14.17.5 - /usr/local/opt/node@14/bin/node
    Yarn: Not Found
    npm: 6.14.14 - /usr/local/opt/node@14/bin/npm
  Browsers:
    Chrome: Not Found
    Edge: Not Found
    Firefox: Not Found [... actually used 95.0b7 (64-bit) Developer Edition ...]
    Safari: 15.0 
  npmPackages:
    @emotion/react: ^11.5.0 => 11.5.0 
    @emotion/styled: ^11.3.0 => 11.3.0 
    @mui/core:  5.0.0-alpha.54 
    @mui/icons-material: ^5.1.0 => 5.1.0 
    @mui/material: ^5.1.0 => 5.1.0 
    @mui/private-theming:  5.1.0 
    @mui/styled-engine:  5.1.0 
    @mui/styled-engine-sc: ^5.1.0 => 5.1.0 
    @mui/styles: ^5.1.0 => 5.1.0 
    @mui/system:  5.1.0 
    @mui/types: ^7.1.0 => 7.1.0 
    @mui/utils:  5.1.0 
    @types/react: ^17.0.11 => 17.0.11 
    react: 17.0.2 => 17.0.2 
    react-dom: 17.0.2 => 17.0.2 
    styled-components: ^5.3.3 => 5.3.3 
    typescript: ~4.3.5 => 4.3.5 

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with plain Select and MenuItem using the createTheme configuration shown, then inspect how the MuiMenuItem style override competes with the generated MuiButtonBase-root-MuiMenuItem-root rule. Done means the theme's minHeight override takes precedence without requiring a per-instance workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.