[BottomNavigation] Label font-size shoud not increase when selected
Open
Nobody has claimed this yet.
design: material
scope: bottom navigation
waiting for 👍
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Description
- The issue is present in the latest release.
- I have searched the issues of this repository and believe that this is not a duplicate.
Current Behavior 😯
The font size increases: https://github.com/mui-org/material-ui/blob/d4ea4c90cb4a82dbe21ecf51b3cd634c5df54b62/packages/mui-material/src/BottomNavigationAction/BottomNavigationAction.js#L67
Expected Behavior 🤔
https://material.io/components/bottom-navigation
Steps to Reproduce 🕹
- Open https://mui.com/components/bottom-navigation/#bottom-navigation
- Click on a new action
- See how the dimension changes
- Compare to https://material.io/components/bottom-navigation
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/mui-material/src/BottomNavigationAction/BottomNavigationAction.js at the linked line, then reproduce the size change from the Bottom Navigation demo. Compare the selected-label behavior with the linked Material Design reference and inspect the component's existing tests if present. Done means selecting an action no longer changes the label font size or layout unexpectedly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- design, frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100