mui / mui/material-ui

Page becomes unresponsive after closing a modal in iOS webkit, safari & chrome

Open
#25,371 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

external dependency scope: all components
Dominant language
JavaScript
Stars
99.1k
Forks
32.5k
Avg merge
2d 17h
Merged PRs (30d)
106

Description

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

After closing a modal the screen becomes unresponsive to press/click events until the page is scrolled again. This is only an issue on iOS (simulators and real devices). It also only happens after you have scrolled down the page. See the video: https://photos.app.goo.gl/8GXMzb5iEUKC11jw9

Note, in the video it works as expected until I scroll down the page.

Expected Behavior 🤔

After closing a modal the page should respond to press/click events.

Steps to Reproduce 🕹

Steps:

  1. Visit https://book.secretspa.co.uk/categories/Nails on an iPhone
  2. Scroll down the page
  3. Press a treatments "Book Now" button
  4. Close the modal that opens
  5. Try and press on another element
  6. It doesn't always happen so I suggest trying a few times.

Context 🔦

I have tried to reproduce this in a codepen but it seemed to work as expected. I've inspected the DOM on the website in question when the issue happens and there's nothing I can see that is overlapping the view.

I understand this is a difficult bug to help with as I cannot provide a code pen example, however I wonder if anyone might be able to suggest why this is happening so I can hunt down the issue.

Your Environment 🌎

System: OS: macOS 11.2.3 Binaries: Node: 12.19.0 - /usr/local/bin/node Yarn: 1.21.1 - /usr/local/bin/yarn npm: 6.14.8 - /usr/local/bin/npm Browsers: Chrome: 89.0.4389.82 Edge: Not Found Firefox: Not Found Safari: 14.0.3 npmPackages: @material-ui/core: ^4.11.0 => 4.11.3 @material-ui/icons: ^4.11.0 => 4.11.2 @material-ui/lab: ^4.0.0-alpha.57 => 4.0.0-alpha.57 @material-ui/pickers: 3.2.10 => 3.2.10 @material-ui/styles: 4.11.3 @material-ui/system: 4.11.3 @material-ui/types: 5.1.0 @material-ui/utils: 4.11.2 @types/react: ^16.9.19 => 16.9.34 react: ^17.0.0 => 17.0.1 react-dom: ^17.0.0 => 17.0.1 typescript: ^4.1.3 => 4.1.5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue at https://book.secretspa.co.uk/categories/Nails on an iPhone: scroll down, open a treatment modal, close it, and test another element. Compare the behavior in iOS Safari and Chrome, repeating the sequence because the failure is intermittent; done means the page remains responsive after the modal closes.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.