[chip] Rename onDelete and deleteIcon
Open
Nobody has claimed this yet.
breaking change
discussion
scope: chip
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Description
Even the docs show onDelete and deleteIcon used for purposes other than deleting the Chip. I'd imagine it's common to use them for other purposes.
I propose renaming them to onSecondaryAction and secondaryIcon, or something similar. The current attributes could be aliases for those so as to not be a breaking change, at least for v4.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.