[Collapse] Transition Breaks Inside Popover
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 99.1k
- Forks
- 32.5k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 106
Description
- I have searched the issues of this repository and believe that this is not a duplicate.
Expected Behavior
Unless I'm missing something, the Collapse transition should work as part of a Menu/Popover like the rest of the transitions.
Current Behavior
When setting Collapse as the TransitionComponent, the Menu/Popover contents appear at 0,0 and there is no animation.
Steps to Reproduce (for bugs)
This can be seen by adding TransitionComponent={Collapse} to the Menu demo.
https://codesandbox.io/s/pxv0jkq3x Edit @eps1lon: https://codesandbox.io/s/menu-collapse-iliwj
Your Environment
| Tech | Version |
|---|---|
| Material-UI | v1.0.0-beta.47 |
| React | 16.3.2 |
| browser | Chrome/Firefox tested. |
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Menu demo and reproduce the issue by setting TransitionComponent={Collapse}; compare its behavior with the other transitions used by Menu/Popover. Done means the contents no longer appear at 0,0 and the Collapse transition animates correctly in the demo.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100