[combobox] Popup as aside menu on mobile device
- Dominant language
- TypeScript
- Stars
- 10.9k
- Forks
- 543
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 101
Description
In variant 2, I'm using Dialog. And here nothing works for me. After closing, my filtered options don't reset. And my input doesn't behave the same way as inside Combobox.Popup, which is the behavior closest to what I want. The issue with option filtering inside Dialog was fixed in multiple mode, but it remains relevant in single mode. So I do it as in variant 1, where I don't pass styles for Positioner. And everything works wonderfully. I'd like to see improvements in this implementation. If using variant 1, I would prefer not to use the Positioner layer at all and would like to have Combobox.Close. If using variant 2, I would like the input to behave the same as inside Combobox.Popup and have working filtering. And when using inside Dialog in multiple mode, the filter resets without waiting for the dialog closing animation to finish, so I would also prefer to use variant 1, but in a cleaner way without a hard dependency on Combobox.Positioner.
https://codesandbox.io/p/sandbox/mystifying-dust-x86q65?file=%2Fsrc%2Fmobile-combobox-1%2Fmobile-combobox-1.tsx%3A14%2C41
Contributor guide
Assessment
This issue has not been assessed yet.