mudler / mudler/vllm.cpp

A18: reference-audio delivery is a product decision, not a port — its only upstream caller is DubIt, which this tree does not ship

Open
#2,634 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
423
Forks
53
Avg merge
20h 26m
Merged PRs (30d)
310

Description

Row: LTX25-REF-AUDIO-DELIVERY

Derivation: .agents/specs/ltx25-ref-audio-delivery.md, landed with this issue.
Split from the A18 row of .agents/specs/ltx25-completion-scope.md §4, whose
sizing this issue contradicts.

A18 of the LTX-2.5 completion scope: reference-AUDIO conditioning delivery.
Refused at src/vllm/multimodal/ltx2_video.cpp:2934-2947.

This is a decision, not a port

The scope document sizes A18 M, "the op is ported and undriven", and orders
it at 10 behind A19. Reading the item's consumer rather than its operator
contradicts that.

At the pinned Lightricks/LTX-2 @ fd4ded7f, over packages/:

git grep -n 'AudioConditionByReferenceLatent(' -- packages/
  packages/ltx-pipelines/src/ltx_pipelines/dubit.py:272

One caller. The only inference-side delivery of this conditioning item lives
inside DubItPipelineA3, which this tree does not ship
(ltx2_pipeline.h:876). Every other upstream pipeline hands its audio
ModalitySpec no conditionings at all: a2vid_two_stage.py:251-256 and
:291-296 freeze on an initial_latent, which is the arm this tree already
serves.

The refusal names the wrong mechanism as its own blocker

The message cites ltx-pipelines/utils/helpers.py:264-269 as what it needs.
That is audio_latent_from_file, whose only inference caller is
retake.py:250 and which ends in _conform_latent_length — it produces
retake's initial latent and never touches the conditioning item. This message
had already been edited twice to retract earlier false reasons.

There is no geometry to mirror

Two upstream consumers disagree, and neither is a default:

Consumer Position convention
dubit.py:351-353 shifts by -(aud_dur + 0.04), documented Dub-It-only at packages/ltx-pipelines/CLAUDE.md:85
ltx-trainer/.../validation_runner.py:759-784 plain, non-negative

So "mirror vLLM" cannot arbitrate it.

Local cost the sizing did not count

StreamState (ltx2_video.cpp:181-192) is a different type from
Ltx2LatentState (ltx2_conditioning.h:94+); bridging them is already called
"its own change" by ltx25-a2v-audio-input.md's ## Owed. And there is no
audio-side trim at all
: target_tokens is video-only (:3753),
Ltx2ClearConditioning runs on video alone (:5045), the invariant at
:5071-5072 checks video only, and :5090 unpatchifies the live audio buffer
with the target ashape.

What a decision needs to answer

  • (a) Withdraw A18 as an independent row and fold the delivery into A3,
    recording Ltx2ConditionAudioByReference as owed by that row. Recommended in
    the spec.
  • (b) Fund it as an engine-defined extension with no upstream referent. Needs
    a ratified product decision, a chosen position convention, a divergence note,
    and reclassification out of class A.
  • (c) Repair the refusal text and the scope record only.

The operator-owned scope document is not edited from here; the contradiction
is recorded in the row spec instead, as #2584 did for A8.

Unverified

Whether the LTX-2.5 checkpoints were trained with a reference-audio condition on
non-DubIt pipelines at all is unmeasured. It needs a real-checkpoint render
and a GPU lease.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .agents/specs/ltx25-ref-audio-delivery.md and the A18 section of .agents/specs/ltx25-completion-scope.md, then inspect the refusal at src/vllm/multimodal/ltx2_video.cpp:2934-2947 and the cited upstream callers. Compare the DubIt and trainer position conventions and the local state and trimming paths. Done means recording a ratified product decision, including the chosen convention and scope outcome, or correcting only the refusal and scope records.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
ai
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.